Bug 114727

Summary: Gradient: add PlatformGradient definition for BlackBerry
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111729    
Attachments:
Description Flags
Patch
cgarcia: review-, cgarcia: commit-queue-
Patch none

Alberto Garcia
Reported 2013-04-17 02:16:24 PDT
PlatformGradient is not defined for BlackBerry in Gradient.h
Attachments
Patch (1.15 KB, patch)
2013-04-17 02:17 PDT, Alberto Garcia 		cgarcia: review-
cgarcia: commit-queue-
DetailsFormatted DiffDiff
Patch (1.18 KB, patch)
2013-04-22 01:11 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-04-17 02:17:34 PDT
Created attachment 198486 [details] Patch
Carlos Garcia Campos
Comment 2 2013-04-22 00:55:51 PDT
Comment on attachment 198486 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198486&action=review > Source/WebCore/platform/graphics/Gradient.h:62 > + class Gradient; This should not be indented, I wonder why the the style checker hasn't caught this, maybe because of the multiple namespaces in the same line which is not common in WebKit code either.
Alberto Garcia
Comment 3 2013-04-22 01:11:05 PDT
Created attachment 198997 [details] Patch Here's the updated patch.
WebKit Commit Bot
Comment 4 2013-04-22 01:58:09 PDT
Comment on attachment 198997 [details] Patch Clearing flags on attachment: 198997 Committed r148864: <http://trac.webkit.org/changeset/148864>
WebKit Commit Bot
Comment 5 2013-04-22 01:58:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.