Bug 113355

Summary:

Mac: Media Controls always hide time display elements

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

Media

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cbiesinger, dglazkov, eric.carlson, eric, esprehn+autocc, feature-media-reviews, macpherson, menard, ojan.autocc, ojan, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from gce-cr-linux-01 for chromium-linux-x86_64	none
Patch	eric.carlson: review+

Jer Noble

Reported 2013-03-26 16:57:16 PDT

Probably caused by <http://trac.webkit.org/changeset/145588>, the fix for bug 110913.

Attachments
Patch (533.07 KB, patch) 2013-03-26 18:12 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-01 for chromium-linux-x86_64 (818.97 KB, application/zip) 2013-03-26 19:15 PDT, WebKit Review Bot	no flags	Details
Patch (533.91 KB, patch) 2013-03-26 22:59 PDT, Jer Noble	eric.carlson: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2013-03-26 18:12:00 PDT

Created attachment 195204 [details] Patch

WebKit Review Bot

Comment 2 2013-03-26 19:15:26 PDT

Comment on attachment 195204 [details] Patch Attachment 195204 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17258578 New failing tests: media/media-document-audio-repaint.html media/video-no-audio.html media/controls-strict.html media/controls-styling.html media/video-display-toggle.html media/controls-styling-strict.html media/audio-repaint.html media/audio-controls-rendering.html media/video-zoom-controls.html fast/hidpi/video-controls-in-hidpi.html media/video-controls-rendering.html media/controls-without-preload.html platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi.html media/media-controls-clone.html fast/layers/video-layer.html media/track/track-cue-rendering-vertical.html media/video-empty-source.html media/video-playing-and-pause.html media/track/track-cue-rendering-horizontal.html media/controls-after-reload.html

WebKit Review Bot

Comment 3 2013-03-26 19:15:29 PDT

Created attachment 195208 [details] Archive of layout-test-results from gce-cr-linux-01 for chromium-linux-x86_64 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-01 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

Jer Noble

Comment 4 2013-03-26 22:59:13 PDT

Created attachment 195227 [details] Patch Made the time display elements back into flexboxes on Chromium.

Jer Noble

Comment 5 2013-03-27 09:27:30 PDT

<rdar://problem/13516141>

Jer Noble

Comment 6 2013-03-27 09:42:19 PDT

Committed r146992: <http://trac.webkit.org/changeset/146992>

Christian Biesinger

Comment 7 2013-03-27 10:21:27 PDT

(cc ojan, fyi the fix for the audio controls)

Note You need to log in before you can comment on or make changes to this bug.