Bug 113170

Summary: WTF::binarySearchImpl() should compile with -Wshorten-64-to-32
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Web Template FrameworkAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, darin, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107093    
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2013-03-24 21:05:48 PDT
/usr/local/include/wtf/StdLibExtras.h:190:30: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32] int pos = (size - 1) >> 1; ~~~ ~~~~~~~~~~~^~~~ 1 error generated.
Attachments
Patch v1 (1.56 KB, patch)
2013-03-24 21:10 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2013-03-24 21:10:36 PDT
Created attachment 194787 [details] Patch v1
WebKit Review Bot
Comment 2 2013-03-25 08:27:52 PDT
Comment on attachment 194787 [details] Patch v1 Clearing flags on attachment: 194787 Committed r146774: <http://trac.webkit.org/changeset/146774>
WebKit Review Bot
Comment 3 2013-03-25 08:27:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.