Bug 109410

Summary: Move WebVTTToken off of MarkupTokenBase
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dgorbik, eric.carlson, ojan.autocc, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107522    
Attachments:
Description Flags
Patch
none
Patch none

Eric Seidel (no email)
Reported 2013-02-11 01:31:49 PST
Move WebVTTToken off of MarkupTokenBase
Attachments
Patch (4.91 KB, patch)
2013-02-11 01:33 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (5.03 KB, patch)
2013-02-11 01:43 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2013-02-11 01:33:28 PST
Created attachment 187525 [details] Patch
Eric Seidel (no email)
Comment 2 2013-02-11 01:34:58 PST
After this lands, MarkupTokenBase will only be used by HTMLToken and thus can just be moved into HTMLToken.
Eric Seidel (no email)
Comment 3 2013-02-11 01:43:05 PST
Created attachment 187527 [details] Patch
Tony Gentilcore
Comment 4 2013-02-11 09:48:11 PST
Comment on attachment 187527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187527&action=review > Source/WebCore/html/track/WebVTTToken.h:70 > + return m_data; Do we need to ASSERT the type is start or end tag here?
Eric Seidel (no email)
Comment 5 2013-02-11 09:51:20 PST
Comment on attachment 187527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187527&action=review >> Source/WebCore/html/track/WebVTTToken.h:70 >> + return m_data; > > Do we need to ASSERT the type is start or end tag here? The old impl didn't, so I'm inclined to leave it off for now. The goal was to maintain compat with the previous impl (while removing the dead code).
Tony Gentilcore
Comment 6 2013-02-11 09:52:17 PST
(In reply to comment #5) > (From update of attachment 187527 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=187527&action=review > > >> Source/WebCore/html/track/WebVTTToken.h:70 > >> + return m_data; > > > > Do we need to ASSERT the type is start or end tag here? > > The old impl didn't, so I'm inclined to leave it off for now. The goal was to maintain compat with the previous impl (while removing the dead code). OK
WebKit Review Bot
Comment 7 2013-02-11 09:56:32 PST
Comment on attachment 187527 [details] Patch Clearing flags on attachment: 187527 Committed r142484: <http://trac.webkit.org/changeset/142484>
WebKit Review Bot
Comment 8 2013-02-11 09:56:35 PST
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 9 2013-02-11 10:43:35 PST
Comment on attachment 187527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187527&action=review > Source/WebCore/html/track/WebVTTToken.h:206 > + DataVector m_data; > DataVector m_annotation; > DataVector m_classes; > DataVector m_currentBuffer; Wow that's a lot of storage!
Note You need to log in before you can comment on or make changes to this bug.