Bug 108489

Summary: Add a watchlist message for WebKit2 OWNERS approval.
Product: WebKit Reporter: Mike West <mkwst>
Component: WebKit2Assignee: Mike West <mkwst>
Status: ASSIGNED    
Severity: Normal CC: abarth, andersca, dpranke, eric, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Whitespace, my old nemesis. abarth: review+

Mike West
Reported 2013-01-31 08:44:53 PST
In the fairly mechanical patch for https://bugs.webkit.org/show_bug.cgi?id=108476, I touched WebKit2 code without noticing. It would be a good idea, I think, if the watchlist would note the necessity of owners approval in the same way that it currently does for the Chromium public API. I've suggested "Please wait for approval from a member of the WebKit2 OWNERS filebefore submitting this patch, as it contains changes to WebKit2.", but I'm of course happy to change the wording to whatever the WebKit2 team would prefer. :)
Attachments
Patch (1.99 KB, patch)
2013-01-31 08:46 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Whitespace, my old nemesis. (1.99 KB, patch)
2013-01-31 08:51 PST, Mike West 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2013-01-31 08:46:22 PST
Created attachment 185792 [details] Patch
Mike West
Comment 2 2013-01-31 08:51:21 PST
Created attachment 185793 [details] Whitespace, my old nemesis.
Adam Barth
Comment 3 2013-01-31 10:54:46 PST
Comment on attachment 185793 [details] Whitespace, my old nemesis. View in context: https://bugs.webkit.org/attachment.cgi?id=185793&action=review > Tools/Scripts/webkitpy/common/config/watchlist:461 > + "WebKit2OWNERS": [ "Please wait for approval from a member of the WebKit2 OWNERS file " > + "before submitting this patch, as it contains changes to WebKit2.", ], http://trac.webkit.org/browser/trunk/Source/WebKit2/Owners <--- Note that it's "Owners" rather than "OWNERS".
Mike West
Comment 4 2013-01-31 12:03:45 PST
(In reply to comment #3) > (From update of attachment 185793 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185793&action=review > > > Tools/Scripts/webkitpy/common/config/watchlist:461 > > + "WebKit2OWNERS": [ "Please wait for approval from a member of the WebKit2 OWNERS file " > > + "before submitting this patch, as it contains changes to WebKit2.", ], > > http://trac.webkit.org/browser/trunk/Source/WebKit2/Owners <--- Note that it's "Owners" rather than "OWNERS". I'll fix that, thanks for the review. I'd appreciate someone on the Owners list weighing in here before I land this, however, since it affects how the change in process is presented to developers. I think the text is uncontroversial, but I'd like confirmation of that. :)
Note You need to log in before you can comment on or make changes to this bug.