Bug 107542

Summary: Move top layer flag from ElementRareData to NodeFlags
Product: WebKit Reporter: Matt Falkenhagen <falken>
Component: Layout and RenderingAssignee: Matt Falkenhagen <falken>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, eric, jchaffraix, morrita, ojan.autocc, ojan, rniwa, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Matt Falkenhagen
Reported 2013-01-22 03:01:16 PST
Try moving the top layer flag from ElementRareData to NodeFlags. It may fix the perf regression described in bug 106726, and has been suggested earlier, e.g., https://bugs.webkit.org/show_bug.cgi?id=84796#c31 Moving it to NodeFlags also simplifies some of the code and makes it no longer necessary to allocate rare data.
Attachments
Patch (9.76 KB, patch)
2013-01-22 03:12 PST, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Falkenhagen
Comment 1 2013-01-22 03:12:28 PST
Created attachment 183951 [details] Patch
WebKit Review Bot
Comment 2 2013-01-22 04:16:43 PST
Comment on attachment 183951 [details] Patch Clearing flags on attachment: 183951 Committed r140411: <http://trac.webkit.org/changeset/140411>
WebKit Review Bot
Comment 3 2013-01-22 04:16:47 PST
All reviewed patches have been landed. Closing bug.
Ojan Vafai
Comment 4 2013-01-22 13:42:04 PST
Doesn't look like it fixed the performance regression. :(
Note You need to log in before you can comment on or make changes to this bug.