Bug 106860

Summary: Split SelectorChecker's fast-checking logic into its own class.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, eric, esprehn+autocc, gyuyoung.kim, kling, koivisto, macpherson, menard, ojan.autocc, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89879    
Attachments:
Description Flags
WIP
none
Things work.
none
Rebased, ready for EWS bubbles.
none
Awesome.
none
Patch
none
Patch for landing none

Dimitri Glazkov (Google)
Reported 2013-01-14 20:00:39 PST
Split SelectorChecker's fast-checking logic into its own class.
Attachments
WIP (18.65 KB, patch)
2013-01-14 20:00 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Things work. (49.00 KB, patch)
2013-01-17 20:55 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Rebased, ready for EWS bubbles. (41.02 KB, patch)
2013-01-18 10:58 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Awesome. (41.07 KB, patch)
2013-01-18 21:07 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch (65.30 KB, patch)
2013-02-16 15:58 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch for landing (34.92 KB, patch)
2013-02-21 20:55 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2013-01-14 20:00:55 PST
Created attachment 182687 [details] WIP
Dimitri Glazkov (Google)
Comment 2 2013-01-17 20:55:45 PST
Created attachment 183362 [details] Things work.
Dimitri Glazkov (Google)
Comment 3 2013-01-18 10:58:19 PST
Created attachment 183507 [details] Rebased, ready for EWS bubbles.
Dimitri Glazkov (Google)
Comment 4 2013-01-18 14:18:13 PST
Comment on attachment 183507 [details] Rebased, ready for EWS bubbles. Bubbles say "yay". Antti, Eric -- wdyt?
Build Bot
Comment 5 2013-01-18 15:00:20 PST
Comment on attachment 183507 [details] Rebased, ready for EWS bubbles. Attachment 183507 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15942697
Dimitri Glazkov (Google)
Comment 6 2013-01-18 21:07:08 PST
Created attachment 183599 [details] Awesome.
Antti Koivisto
Comment 7 2013-01-19 04:58:37 PST
Comment on attachment 183599 [details] Awesome. View in context: https://bugs.webkit.org/attachment.cgi?id=183599&action=review Looks pretty good. Please hold this until kling gets his complicated CSSSelector changes in though. > Source/WebCore/css/FastPathSelectorMatcher.h:39 > + FastPathSelectorMatcher(CSSSelector*, Element*); I think the naming should be consistent with SelectorChecker. I'd also prefer prefix style naming for subsystems. This one could be SelectorCheckerFastPath. What do you think? > Source/WebCore/css/FastPathSelectorMatcher.h:45 > + static bool canUseFastPath(const CSSSelector*); FastPath is redundant.
Darin Adler
Comment 8 2013-01-19 08:26:40 PST
Comment on attachment 183599 [details] Awesome. View in context: https://bugs.webkit.org/attachment.cgi?id=183599&action=review >> Source/WebCore/css/FastPathSelectorMatcher.h:39 >> + FastPathSelectorMatcher(CSSSelector*, Element*); > > I think the naming should be consistent with SelectorChecker. I'd also prefer prefix style naming for subsystems. This one could be SelectorCheckerFastPath. What do you think? For what it’s worth, I agree with both of Antti’s suggestions here and I think SelectorCheckerFastPath is a good name.
Dimitri Glazkov (Google)
Comment 9 2013-01-19 08:33:59 PST
(In reply to comment #8) > (From update of attachment 183599 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=183599&action=review > > >> Source/WebCore/css/FastPathSelectorMatcher.h:39 > >> + FastPathSelectorMatcher(CSSSelector*, Element*); > > > > I think the naming should be consistent with SelectorChecker. I'd also prefer prefix style naming for subsystems. This one could be SelectorCheckerFastPath. What do you think? > > For what it’s worth, I agree with both of Antti’s suggestions here and I think SelectorCheckerFastPath is a good name. SelectorCheckerFastPath it is! Man, I totally wanted to punk Kling and land this before him :P
Dimitri Glazkov (Google)
Comment 10 2013-02-16 15:58:19 PST
Created attachment 188737 [details] Patch
Eric Seidel (no email)
Comment 11 2013-02-20 22:53:46 PST
Are you just waiting for love here dglazkov?
Antti Koivisto
Comment 12 2013-02-21 03:52:18 PST
Comment on attachment 188737 [details] Patch r=me, looks good
Dimitri Glazkov (Google)
Comment 13 2013-02-21 20:55:13 PST
Created attachment 189671 [details] Patch for landing
WebKit Review Bot
Comment 14 2013-02-21 21:17:20 PST
Comment on attachment 189671 [details] Patch for landing Clearing flags on attachment: 189671 Committed r143686: <http://trac.webkit.org/changeset/143686>
WebKit Review Bot
Comment 15 2013-02-21 21:17:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.