Bug 102299

Summary: Add a new shared class WebCoreFullScreenWarningView which presents a styled warning message.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 102300    
Attachments:
Description Flags
Patch ap: review+

Jer Noble
Reported 2012-11-14 16:38:52 PST
Add a new shared class WebCoreFullScreenWarningView which presents a styled warning message.
Attachments
Patch (14.18 KB, patch)
2012-11-14 16:59 PST, Jer Noble 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2012-11-14 16:59:06 PST
Created attachment 174290 [details] Patch
Alexey Proskuryakov
Comment 2 2012-11-16 12:58:12 PST
Comment on attachment 174290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174290&action=review I don't know why anyone in the world would do layout with anything other than HTML :-p r=style bot > Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm:28 > +#include "WebCoreFullScreenWarningView.h" > +#include "LocalizedStrings.h" There should be a blank line between these. > Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm:45 > +static const NSTimeInterval WarningViewHideDelay = 3.0; You got all of them right, except for this one, should be just "3". > Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm:66 > + RetainPtr<NSFont> textFont = [NSFont boldSystemFontOfSize:WarningViewTextSize]; No good in retaining it, just refcount churn. > Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm:67 > + RetainPtr<NSColor> textColor = [NSColor colorWithCalibratedWhite:WarningViewTextWhite alpha:WarningViewTextAlpha]; No good in retaining it, just refcount churn. > Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm:91 > + RetainPtr<NSColor> backgroundColor = [NSColor colorWithCalibratedWhite:WarningViewBackgroundWhite alpha:WarningViewBackgroundAlpha]; No good in retaining it, just refcount churn. > Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm:99 > + RetainPtr<NSColor> shadowColor = [NSColor colorWithCalibratedWhite:WarningViewShadowWhite alpha:WarningViewShadowAlpha]; No good in retaining it, just refcount churn.
Jer Noble
Comment 3 2012-11-27 16:24:42 PST
Committed r135937: <http://trac.webkit.org/changeset/135937>
Note You need to log in before you can comment on or make changes to this bug.