Bug 101465

Summary: [Qt][ARM] REGRESSION(r133688): It made all JSC and layout tests crash on ARM traditional platform
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: fpizlo, gaborb, loki, oliver, ossy, webkit.review.bot, zherczeg
Priority: P1 Keywords: Qt, QtTriaged
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79668, 101127    
Attachments:
Description Flags
Fix none

Csaba Osztrogonác
Reported 2012-11-07 06:30:42 PST
Unfortunately there isn't any useful log uploaded by the bot: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7303
Attachments
Fix (1.26 KB, patch)
2012-11-07 07:32 PST, Gabor Ballabas 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Ballabas
Comment 1 2012-11-07 06:35:55 PST
Some debug info. Program received signal SIGSEGV, Segmentation fault. 0x0009af70 in JSC::CodeBlock::CodeBlock (this=0x7b7bb0, ownerExecutable=0x42c7c900, unlinkedCodeBlock=0x42dbfd50, globalObject=0x42c9fa40, baseScopeDepth=0, sourceProvider=..., sourceOffset=0, alternative=...) at /home/bgabor/WebKit/Source/JavaScriptCore/bytecode/CodeBlock.cpp:1829 1829 CRASH(); (gdb) Continuing. [Thread 0x42850450 (LWP 3590) exited] [Inferior 1 (process 3589) exited with code 013] (gdb) l 1824 case op_get_by_id_custom_proto: 1825 case op_get_by_id_custom_chain: 1826 case op_get_by_id_generic: 1827 case op_get_array_length: 1828 case op_get_string_length: 1829 CRASH(); 1830 1831 case op_init_global_const_nop: { 1832 ASSERT(codeType() == GlobalCode); 1833 Identifier ident = identifier(pc[i + 4].u.operand);
Gabor Ballabas
Comment 2 2012-11-07 07:10:08 PST
Fix is coming just checking with the whole javascriptcore test-suite.
Gabor Ballabas
Comment 3 2012-11-07 07:32:25 PST
Created attachment 172798 [details] Fix
Oliver Hunt
Comment 4 2012-11-07 09:44:48 PST
Comment on attachment 172798 [details] Fix Gah! Damnit, thanks Gabor.
WebKit Review Bot
Comment 5 2012-11-07 09:51:56 PST
Comment on attachment 172798 [details] Fix Rejecting attachment 172798 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: mit-queue/Source/WebKit/chromium/third_party/skia/gyp --revision 6303 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 45>At revision 6303. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14755531
Csaba Osztrogonác
Comment 6 2012-11-07 10:49:35 PST
Comment on attachment 172798 [details] Fix Clearing flags on attachment: 172798 Committed r133781: <http://trac.webkit.org/changeset/133781>
Csaba Osztrogonác
Comment 7 2012-11-07 10:49:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.